fix(docs): keep right menu below sticky header#1425
Open
w3lld1 wants to merge 1 commit into
Open
Conversation
Signed-off-by: w3lld1 <42353747+w3lld1@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep the desktop docs side menu below the sticky header
Fixes #1407
Description
I increased the desktop offset for the API docs side affix so its first entries no longer sit underneath the wrapped sticky header at viewport widths of 1200px and above.
I verified the change against the current 4.8.0-beta00018 docs page by replacing its stylesheet in headless Chromium with this branch's stylesheet. At 1200, 1215, 1280, 1350, and 1600px, the 195px-tall header ends before the side menu starts at 200px, and every visible menu entry remains inside the viewport.
Validation
uvx prek run --files websites/apidocs/Templates/LuceneTemplateAssets/styles/main.cssgit diff --check origin/master...HEADI did not run the complete Windows-based DocFX website build locally; the browser regression check exercises the changed stylesheet against the published docs markup.